Skip to content

Fix licence handling - #2802

Merged
Ricardo Salveti (ricardosalveti) merged 35 commits into
qualcomm-linux:masterfrom
lumag:fix-licences
Aug 11, 2026
Merged

Fix licence handling#2802
Ricardo Salveti (ricardosalveti) merged 35 commits into
qualcomm-linux:masterfrom
lumag:fix-licences

Conversation

@lumag

@lumag Dmitry Baryshkov (lumag) commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

OE-Core is has switched to use SPDX licence expression. Follow the change, removing the warnings generated by the layer. Also a lot of recipes here were not able to specify the licence for the repackaged firmware, so drop them from this layer. They will be moved to a separate layer later on.

@koenkooi

Copy link
Copy Markdown
Contributor

Nice work, the CI errors seem to be unrelated:

/work/build/tmp/work/armv8a-qcom-linux/xterm/410/temp/log.do_configure.1054257

@quaresmajose

Copy link
Copy Markdown
Contributor

Wouldn't it be better to do this in smaller steps? First the protobuf and abseil-cpp bump and our fixes and next the oe-core tip.

Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference the recipe-specific licence. The licence name is
used as a BitBake variable flag name, so replace underscore with the
dash symbol.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
…rings

Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Converts all LICENSE strings to SPDX licenses expressions. Use
LicenseRef to reference layer-specific licence.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
The .gitignore file references files which are long unused. Drop it from
the repo.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Modem firmware for the board is provided in the separate layer (or it
can be provisioned by the users directly on the board, while the
packagegroup dependencies are specified in the meta-qcom layer.

Provide the placeholder recipe required to fulfill dependencies.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Modem firmware for the board is provided in the separate layer (or it
can be provisioned by the users directly on the board, while the
packagegroup dependencies are specified in the meta-qcom layer.

Provide the placeholder recipe required to fulfill dependencies.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
The 'CLOSED' licence now triggers the warning in OE-Core's licence
checks. Since these recipes don't have a proper licence and likely never
will, drop them from the layer (as well as the packages which depend on
them).

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Comment thread recipes-bsp/firmware/firmware-qcom-qcm6490-idp.bb
@ricardosalveti

Copy link
Copy Markdown
Contributor

Github PR description also requires an update, since you are not bumping any layer anymore.

@lumag

Copy link
Copy Markdown
Contributor Author

Github PR description also requires an update, since you are not bumping any layer anymore.

Done

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

Test run workflow

Test jobs for commit 2617980

nodistro
Pass: 10 | Fail: 0 | Total: 10
qcom-distro
Pass: 304 | Fail: 0 | Total: 342
qcom-distro_linux-qcom-6.18
Pass: 234 | Fail: 0 | Total: 259

@test-reporting-app

test-reporting-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

Test Results

  117 files    698 suites   7h 39m 0s ⏱️
  157 tests   157 ✅  0 💤 0 ❌
4 498 runs  4 435 ✅ 63 💤 0 ❌

Results for commit 2617980.

♻️ This comment has been updated with latest results.

@qcomlnxci

Copy link
Copy Markdown

Test Coral run workflow

Test jobs for commit 2617980

  • qcomdistro: multimedia image-prop
    Pass: 52 | Fail: 0 | Total: 52
  • qcomdistro: multimedia image
    Pass: 9 | Fail: 0 | Total: 9

@ricardosalveti
Ricardo Salveti (ricardosalveti) merged commit 1229313 into qualcomm-linux:master Aug 11, 2026
273 of 274 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants